strictures-1.005002/000755 000765 000024 00000000000 12251737250 014435 5ustar00gknopstaff000000 000000 strictures-1.005002/Changes000644 000765 000024 00000003325 12251737240 015732 0ustar00gknopstaff000000 000000 Release history for strictures 1.005002 2013-12-10 - extra prereqs will be listed as hard prerequisites if a compiler is available 1.005001 2013-11-07 - fix skip on old perl on test script 1.005000 2013-11-05 - detect mercurial when checking for development trees - avoid using constant.pm to save a bit of memory on older perls - update to v2 metadata 1.004004 2012-11-12 - fix crash in 1.004003 due to qw() list being readonly 1.004003 2012-11-10 - check only once for presence of extra testing prereqs - explicitly specify no dynamic_config in META 1.004002 2012-09-08 - add better rationale for the extra testing heuristic 1.004001 2012-07-12 - test-specific strictures now enabled during 'dzil test' 1.004000 2012-07-12 - switch to testing calling file to avoid firing on dependencies 1.003001 2012-04-08 - fix test to handle defatalization 1.003000 2012-04-07 - try and run for any checkout t/ now we don't blow up the process - defatalize lack of extra testing modules - disable extra tests on perls <= 5.008003, things do not work there as expected 1.002002 2011-02-25 - only try and mkdir the .git if it doesn't already exist so repeated test runs don't explode 1.002001 2011-02-25 - switch .svn to .git in smells-of-vcs test and create it ourselves to ease importing of this dist into subversion repositories 1.002000 2011-02-16 - add multidimensional and bareword::filehandles in author mode 1.1.1 2010-12-05 - disable uninitialized warnings before calling ->SUPER::VERSION 1.1.0 2010-11-22 - enable extra testing only if .git or .svn present to keep requirement for extra modules author-side 1.0.0 2010-07-18 - initial release strictures-1.005002/lib/000755 000765 000024 00000000000 12251737250 015203 5ustar00gknopstaff000000 000000 strictures-1.005002/maint/000755 000765 000024 00000000000 12251737250 015545 5ustar00gknopstaff000000 000000 strictures-1.005002/Makefile.PL000644 000765 000024 00000002456 12250333356 016414 0ustar00gknopstaff000000 000000 use strict; use warnings FATAL => 'all'; use ExtUtils::MakeMaker; (do 'maint/Makefile.PL.include' or die $@) unless -f 'META.yml'; my %extra_prereqs = ( indirect => 0, multidimensional => 0, 'bareword::filehandles' => 0, ); my $have_compiler = eval { require ExtUtils::CBuilder; 1 } && ExtUtils::CBuilder->new->have_compiler; WriteMakefile( NAME => 'strictures', VERSION_FROM => 'lib/strictures.pm', MIN_PERL_VERSION => '5.006', META_MERGE => { 'meta-spec' => { version => 2 }, dynamic_config => 1, resources => { # r/w: p5sagit@git.shadowcat.co.uk:strictures.git repository => { url => 'git://git.shadowcat.co.uk/p5sagit/strictures.git', web => 'http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/strictures.git', type => 'git', }, bugtracker => { mailto => 'bug-strictures@rt.cpan.org', web => 'https://rt.cpan.org/Public/Dist/Display.html?Name=strictures', }, }, prereqs => { configure => { requires => { 'ExtUtils::CBuilder' => 0, }, }, runtime => { ( $] >= 5.008004 && !$have_compiler ? ( recommends => \%extra_prereqs ) : () ), }, }, }, ($] >= 5.008004 && $have_compiler ? ( PREREQ_PM => \%extra_prereqs ) : () ), ); strictures-1.005002/MANIFEST000644 000765 000024 00000001221 12251737250 015562 0ustar00gknopstaff000000 000000 Changes lib/strictures.pm maint/bump-version maint/Makefile.include maint/Makefile.PL.include Makefile.PL MANIFEST This list of files t/crash.t t/dep_constellations/broken/bareword/filehandles.pm t/dep_constellations/broken/indirect.pm t/dep_constellations/broken/multidimensional.pm t/smells-of-vcs/.exists t/smells-of-vcs/lib/one.pm t/smells-of-vcs/other/one.pl t/smells-of-vcs/t/one.faket t/strictures.t xt/pod.t META.yml Module YAML meta-data (added by MakeMaker) META.json Module JSON meta-data (added by MakeMaker) README README file (added by Distar) strictures-1.005002/META.json000644 000765 000024 00000002621 12251737250 016057 0ustar00gknopstaff000000 000000 { "abstract" : "turn on strict and make all warnings fatal", "author" : [ "mst - Matt S. Trout (cpan:MSTROUT) " ], "dynamic_config" : 1, "generated_by" : "ExtUtils::MakeMaker version 6.82, CPAN::Meta::Converter version 2.132830", "license" : [ "perl_5" ], "meta-spec" : { "url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec", "version" : "2" }, "name" : "strictures", "no_index" : { "directory" : [ "t", "inc" ] }, "prereqs" : { "build" : { "requires" : { "ExtUtils::MakeMaker" : "0" } }, "configure" : { "requires" : { "ExtUtils::CBuilder" : "0" } }, "runtime" : { "requires" : { "bareword::filehandles" : "0", "indirect" : "0", "multidimensional" : "0", "perl" : "5.006" } } }, "release_status" : "stable", "resources" : { "bugtracker" : { "mailto" : "bug-strictures@rt.cpan.org", "web" : "https://rt.cpan.org/Public/Dist/Display.html?Name=strictures" }, "repository" : { "type" : "git", "url" : "git://git.shadowcat.co.uk/p5sagit/strictures.git", "web" : "http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/strictures.git" } }, "version" : "1.005002" } strictures-1.005002/META.yml000644 000765 000024 00000001341 12251737250 015705 0ustar00gknopstaff000000 000000 --- abstract: 'turn on strict and make all warnings fatal' author: - 'mst - Matt S. Trout (cpan:MSTROUT) ' build_requires: ExtUtils::MakeMaker: 0 configure_requires: ExtUtils::CBuilder: 0 dynamic_config: 1 generated_by: 'ExtUtils::MakeMaker version 6.82, CPAN::Meta::Converter version 2.132830' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html version: 1.4 name: strictures no_index: directory: - t - inc requires: bareword::filehandles: 0 indirect: 0 multidimensional: 0 perl: 5.006 resources: bugtracker: https://rt.cpan.org/Public/Dist/Display.html?Name=strictures repository: git://git.shadowcat.co.uk/p5sagit/strictures.git version: 1.005002 strictures-1.005002/README000644 000765 000024 00000016314 12251737250 015322 0ustar00gknopstaff000000 000000 NAME strictures - turn on strict and make all warnings fatal SYNOPSIS use strictures 1; is equivalent to use strict; use warnings FATAL => 'all'; except when called from a file which matches: (caller)[1] =~ /^(?:t|xt|lib|blib)/ and when either ".git", ".svn", or ".hg" is present in the current directory (with the intention of only forcing extra tests on the author side) -- or when ".git", ".svn", or ".hg" is present two directories up along with "dist.ini" (which would indicate we are in a "dzil test" operation, via Dist::Zilla) -- or when the "PERL_STRICTURES_EXTRA" environment variable is set, in which case use strictures 1; is equivalent to use strict; use warnings FATAL => 'all'; no indirect 'fatal'; no multidimensional; no bareword::filehandles; Note that "PERL_STRICTURES_EXTRA" may at some point add even more tests, with only a minor version increase, but any changes to the effect of "use strictures" in normal mode will involve a major version bump. If any of the extra testing modules are not present, strictures will complain loudly, once, via "warn()", and then shut up. But you really should consider installing them, they're all great anti-footgun tools. DESCRIPTION I've been writing the equivalent of this module at the top of my code for about a year now. I figured it was time to make it shorter. Things like the importer in "use Moose" don't help me because they turn warnings on but don't make them fatal -- which from my point of view is useless because I want an exception to tell me my code isn't warnings-clean. Any time I see a warning from my code, that indicates a mistake. Any time my code encounters a mistake, I want a crash -- not spew to STDERR and then unknown (and probably undesired) subsequent behaviour. I also want to ensure that obvious coding mistakes, like indirect object syntax (and not so obvious mistakes that cause things to accidentally compile as such) get caught, but not at the cost of an XS dependency and not at the cost of blowing things up on another machine. Therefore, strictures turns on additional checking, but only when it thinks it's running in a test file in a VCS checkout -- although if this causes undesired behaviour this can be overridden by setting the "PERL_STRICTURES_EXTRA" environment variable. If additional useful author side checks come to mind, I'll add them to the "PERL_STRICTURES_EXTRA" code path only -- this will result in a minor version increase (e.g. 1.000000 to 1.001000 (1.1.0) or similar). Any fixes only to the mechanism of this code will result in a sub-version increase (e.g. 1.000000 to 1.000001 (1.0.1)). If the behaviour of "use strictures" in normal mode changes in any way, that will constitute a major version increase -- and the code already checks when its version is tested to ensure that use strictures 1; will continue to only introduce the current set of strictures even if 2.0 is installed. METHODS import This method does the setup work described above in "DESCRIPTION" VERSION This method traps the "strictures->VERSION(1)" call produced by a use line with a version number on it and does the version check. EXTRA TESTING RATIONALE Every so often, somebody complains that they're deploying via "git pull" and that they don't want strictures to enable itself in this case -- and that setting "PERL_STRICTURES_EXTRA" to 0 isn't acceptable (additional ways to disable extra testing would be welcome but the discussion never seems to get that far). In order to allow us to skip a couple of stages and get straight to a productive conversation, here's my current rationale for turning the extra testing on via a heuristic: The extra testing is all stuff that only ever blows up at compile time; this is intentional. So the oft-raised concern that it's different code being tested is only sort of the case -- none of the modules involved affect the final optree to my knowledge, so the author gets some additional compile time crashes which he/she then fixes, and the rest of the testing is completely valid for all environments. The point of the extra testing -- especially "no indirect" -- is to catch mistakes that newbie users won't even realise are mistakes without help. For example, foo { ... }; where foo is an & prototyped sub that you forgot to import -- this is pernicious to track down since all *seems* fine until it gets called and you get a crash. Worse still, you can fail to have imported it due to a circular require, at which point you have a load order dependent bug which I've seen before now *only* show up in production due to tiny differences between the production and the development environment. I wrote to explain this particular problem before strictures itself existed. As such, in my experience so far strictures' extra testing has *avoided* production versus development differences, not caused them. Additionally, strictures' policy is very much "try and provide as much protection as possible for newbies -- who won't think about whether there's an option to turn on or not" -- so having only the environment variable is not sufficient to achieve that (I get to explain that you need to add "use strict" at least once a week on freenode #perl -- newbies sometimes completely skip steps because they don't understand that that step is important). I make no claims that the heuristic is perfect -- it's already been evolved significantly over time, especially for 1.004 where we changed things to ensure it only fires on files in your checkout (rather than strictures-using modules you happened to have installed, which was just silly). However, I hope the above clarifies why a heuristic approach is not only necessary but desirable from a point of view of providing new users with as much safety as possible, and will allow any future discussion on the subject to focus on "how do we minimise annoyance to people deploying from checkouts intentionally". SEE ALSO * indirect * multidimensional * bareword::filehandles COMMUNITY AND SUPPORT IRC channel irc.perl.org #toolchain (or bug 'mst' in query on there or freenode) Git repository Gitweb is on http://git.shadowcat.co.uk/ and the clone URL is: git clone git://git.shadowcat.co.uk/p5sagit/strictures.git The web interface to the repository is at: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/strictures.git AUTHOR mst - Matt S. Trout (cpan:MSTROUT) CONTRIBUTORS Karen Etheridge (cpan:ETHER) Mithaldu - Christian Walde (cpan:MITHALDU) haarg - Graham Knop (cpan:HAARG) COPYRIGHT Copyright (c) 2010 the strictures "AUTHOR" and "CONTRIBUTORS" as listed above. LICENSE This library is free software and may be distributed under the same terms as perl itself. strictures-1.005002/t/000755 000765 000024 00000000000 12251737250 014700 5ustar00gknopstaff000000 000000 strictures-1.005002/xt/000755 000765 000024 00000000000 12251737250 015070 5ustar00gknopstaff000000 000000 strictures-1.005002/xt/pod.t000644 000765 000024 00000000544 12250200747 016035 0ustar00gknopstaff000000 000000 use Test::More; use Test::Pod; use Test::Pod::Coverage; use strict; use warnings FATAL => 'all'; # the all_ things attempt to plan, which we didn't want, so stop them # from doing that no warnings 'redefine'; local *Test::Builder::plan = sub { }; all_pod_files_ok; all_pod_coverage_ok({ coverage_class => 'Pod::Coverage::CountParents' }); done_testing; strictures-1.005002/t/crash.t000644 000765 000024 00000000454 12250333332 016160 0ustar00gknopstaff000000 000000 use strictures; use Test::More tests => 1; SKIP: { skip 'Have all the modules; can\'t check this', 1 unless not eval { require indirect; require multidimensional; require bareword::filehandles; 1; }; pass('can manage to survive with some modules missing!'); } strictures-1.005002/t/dep_constellations/000755 000765 000024 00000000000 12251737250 020571 5ustar00gknopstaff000000 000000 strictures-1.005002/t/smells-of-vcs/000755 000765 000024 00000000000 12251737250 017372 5ustar00gknopstaff000000 000000 strictures-1.005002/t/strictures.t000644 000765 000024 00000004365 12250333332 017274 0ustar00gknopstaff000000 000000 BEGIN { delete $ENV{PERL_STRICTURES_EXTRA} } # -e is sufficient here. -e 't/smells-of-vcs/.git' or mkdir('t/smells-of-vcs/.git') or die "Couldn't create fake .git: $!"; use Test::More qw(no_plan); our (@us, @expect); sub capture_stuff { [ $^H, ${^WARNING_BITS} ] } sub capture_us { push @us, capture_stuff } sub capture_expect { push @expect, capture_stuff } { BEGIN { $ENV{PERL_STRICTURES_EXTRA} = 0 } use strictures 1; BEGIN { capture_us } BEGIN { delete $ENV{PERL_STRICTURES_EXTRA} } } { use strict; use warnings FATAL => 'all'; BEGIN { capture_expect } } # I'm assuming here we'll have more cases later. maybe not. eh. foreach my $idx (0 .. $#us) { is($us[$idx][0], $expect[$idx][0], 'Hints ok for case '.($idx+1)); is($us[$idx][1], $expect[$idx][1], 'Warnings ok for case '.($idx+1)); } SKIP: { skip 'Extra tests disabled on perls <= 5.008003', 1 if $] < 5.008004; skip 'Not got all the modules to do this', 1 unless eval { require indirect; require multidimensional; require bareword::filehandles; 1; }; sub Foo::new { 1 } chdir("t/smells-of-vcs"); local $strictures::Smells_Like_VCS = 1; foreach my $file (qw(lib/one.pm t/one.faket)) { ok(!eval { require $file; 1 }, "Failed to load ${file}"); like($@, qr{Indirect call of method}, "Failed due to indirect.pm, ok"); } ok(eval { require "other/one.pl"; 1 }, "Loaded other/one.pl ok"); chdir("../.."); } ok(!eval q{use strictures 2; 1; }, "Can't use strictures 2 (this is version 1)"); SKIP: { skip 'Extra tests disabled on perls <= 5.008003', 1 if $] < 5.008004; local $ENV{PERL_STRICTURES_EXTRA} = 1; local $strictures::extra_load_states = undef; local @INC = ("t/dep_constellations/broken", @INC); local %INC = %INC; delete $INC{$_} for qw( indirect.pm multidimensional.pm bareword/filehandles.pm ); { open my $fh, '>', \my $str; local *STDERR = $fh; strictures->import; like( $str, qr/Missing were:\n\n indirect multidimensional bareword::filehandles/, "failure to load all three extra deps is reported" ); } { open my $fh, '>', \my $str; local *STDERR = $fh; strictures->import; ok( !$str, "extra dep load failure is not reported a second time" ); } } strictures-1.005002/t/smells-of-vcs/.exists000644 000765 000024 00000000000 12250200747 020673 0ustar00gknopstaff000000 000000 strictures-1.005002/t/smells-of-vcs/lib/000755 000765 000024 00000000000 12251737250 020140 5ustar00gknopstaff000000 000000 strictures-1.005002/t/smells-of-vcs/other/000755 000765 000024 00000000000 12251737250 020513 5ustar00gknopstaff000000 000000 strictures-1.005002/t/smells-of-vcs/t/000755 000765 000024 00000000000 12251737250 017635 5ustar00gknopstaff000000 000000 strictures-1.005002/t/smells-of-vcs/t/one.faket000644 000765 000024 00000000044 12250200747 021423 0ustar00gknopstaff000000 000000 use strictures 1; new Foo 1, 2, 3; strictures-1.005002/t/smells-of-vcs/other/one.pl000644 000765 000024 00000000044 12250200747 021622 0ustar00gknopstaff000000 000000 use strictures 1; new Foo 1, 2, 3; strictures-1.005002/t/smells-of-vcs/lib/one.pm000644 000765 000024 00000000062 12250200747 021250 0ustar00gknopstaff000000 000000 package one; use strictures 1; new Foo 1, 2, 3; strictures-1.005002/t/dep_constellations/broken/000755 000765 000024 00000000000 12251737250 022051 5ustar00gknopstaff000000 000000 strictures-1.005002/t/dep_constellations/broken/bareword/000755 000765 000024 00000000000 12251737250 023656 5ustar00gknopstaff000000 000000 strictures-1.005002/t/dep_constellations/broken/indirect.pm000644 000765 000024 00000000000 12250200747 024171 0ustar00gknopstaff000000 000000 strictures-1.005002/t/dep_constellations/broken/multidimensional.pm000644 000765 000024 00000000000 12250200747 025745 0ustar00gknopstaff000000 000000 strictures-1.005002/t/dep_constellations/broken/bareword/filehandles.pm000644 000765 000024 00000000000 12250200747 026453 0ustar00gknopstaff000000 000000 strictures-1.005002/maint/bump-version000755 000765 000024 00000001442 12250200747 020115 0ustar00gknopstaff000000 000000 #!/usr/bin/env perl use 5.010; use strict; use warnings FATAL => 'all'; use autodie; chomp(my $LATEST = qx(grep '^[0-9]' Changes | head -1 | awk '{print \$1}')); my @parts = split /\./, $LATEST; my $OLD_DECIMAL = sprintf('%i.%03i%03i', @parts); my %bump_part = (major => 0, minor => 1, bugfix => 2); my $bump_this = $bump_part{$ARGV[0]||'bugfix'} // die "no idea which part to bump - $ARGV[0] means nothing to me"; my @new_parts = @parts; $new_parts[$bump_this]++; my $NEW_DECIMAL = sprintf('%i.%03i%03i', @new_parts); warn "Bumping $OLD_DECIMAL -> $NEW_DECIMAL\n"; my $PM_FILE = 'lib/Module/Metadata.pm'; my $file = do { local (@ARGV, $/) = ($PM_FILE); <> }; $file =~ s/(?<=\$VERSION = ')${\quotemeta $OLD_DECIMAL}/${NEW_DECIMAL}/; open my $out, '>', $PM_FILE; print $out $file; strictures-1.005002/maint/Makefile.include000644 000765 000024 00000000275 12250200747 020626 0ustar00gknopstaff000000 000000 bump: maint/bump-version rm Makefile bumpminor: maint/bump-version minor rm Makefile bumpmajor: maint/bump-version major rm Makefile upload: $(DISTVNAME).tar$(SUFFIX) cpan-upload $< strictures-1.005002/maint/Makefile.PL.include000644 000765 000024 00000000430 12250200747 021131 0ustar00gknopstaff000000 000000 BEGIN { -e 'Distar' or system("git clone git://git.shadowcat.co.uk/p5sagit/Distar.git") } use lib 'Distar/lib'; use Distar; author 'mst - Matt S. Trout (cpan:MSTROUT) '; manifest_include( 't/smells-of-vcs' => qr{.*}, 't/dep_constellations' => '.pm', ); strictures-1.005002/lib/strictures.pm000644 000765 000024 00000022777 12251737167 017776 0ustar00gknopstaff000000 000000 package strictures; use strict; use warnings FATAL => 'all'; BEGIN { *_PERL_LT_5_8_4 = ($] < 5.008004) ? sub(){1} : sub(){0}; } our $VERSION = '1.005002'; # 1.5.2 sub VERSION { for ($_[1]) { last unless defined && !ref && int != 1; die "Major version specified as $_ - this is strictures version 1"; } # disable this since Foo->VERSION(undef) correctly returns the version # and that can happen either if our caller passes undef explicitly or # because the for above autovivified $_[1] - I could make it stop but # it's pointless since we don't want to blow up if the caller does # something valid either. no warnings 'uninitialized'; shift->SUPER::VERSION(@_); } our $extra_load_states; our $Smells_Like_VCS = (-e '.git' || -e '.svn' || -e '.hg' || (-e '../../dist.ini' && (-e '../../.git' || -e '../../.svn' || -e '../../.hg' ))); sub import { strict->import; warnings->import(FATAL => 'all'); my $extra_tests = do { if (exists $ENV{PERL_STRICTURES_EXTRA}) { if (_PERL_LT_5_8_4 and $ENV{PERL_STRICTURES_EXTRA}) { die 'PERL_STRICTURES_EXTRA checks are not available on perls older than 5.8.4: ' . "please unset \$ENV{PERL_STRICTURES_EXTRA}\n"; } $ENV{PERL_STRICTURES_EXTRA}; } elsif (! _PERL_LT_5_8_4) { !!((caller)[1] =~ /^(?:t|xt|lib|blib)/ and $Smells_Like_VCS) } }; if ($extra_tests) { $extra_load_states ||= do { my (%rv, @failed); foreach my $mod (qw(indirect multidimensional bareword::filehandles)) { eval "require $mod; \$rv{'$mod'} = 1;" or do { push @failed, $mod; # courtesy of the 5.8 require bug # (we do a copy because 5.16.2 at least uses the same read-only # scalars for the qw() list and it doesn't seem worth a $^V check) (my $file = $mod) =~ s|::|/|g; delete $INC{"${file}.pm"}; }; } if (@failed) { my $failed = join ' ', @failed; print STDERR <unimport(':fatal') if $extra_load_states->{indirect}; multidimensional->unimport if $extra_load_states->{multidimensional}; bareword::filehandles->unimport if $extra_load_states->{'bareword::filehandles'}; } } 1; __END__ =head1 NAME strictures - turn on strict and make all warnings fatal =head1 SYNOPSIS use strictures 1; is equivalent to use strict; use warnings FATAL => 'all'; except when called from a file which matches: (caller)[1] =~ /^(?:t|xt|lib|blib)/ and when either C<.git>, C<.svn>, or C<.hg> is present in the current directory (with the intention of only forcing extra tests on the author side) -- or when C<.git>, C<.svn>, or C<.hg> is present two directories up along with C (which would indicate we are in a C operation, via L) -- or when the C environment variable is set, in which case use strictures 1; is equivalent to use strict; use warnings FATAL => 'all'; no indirect 'fatal'; no multidimensional; no bareword::filehandles; Note that C may at some point add even more tests, with only a minor version increase, but any changes to the effect of C in normal mode will involve a major version bump. If any of the extra testing modules are not present, L will complain loudly, once, via C, and then shut up. But you really should consider installing them, they're all great anti-footgun tools. =head1 DESCRIPTION I've been writing the equivalent of this module at the top of my code for about a year now. I figured it was time to make it shorter. Things like the importer in C don't help me because they turn warnings on but don't make them fatal -- which from my point of view is useless because I want an exception to tell me my code isn't warnings-clean. Any time I see a warning from my code, that indicates a mistake. Any time my code encounters a mistake, I want a crash -- not spew to STDERR and then unknown (and probably undesired) subsequent behaviour. I also want to ensure that obvious coding mistakes, like indirect object syntax (and not so obvious mistakes that cause things to accidentally compile as such) get caught, but not at the cost of an XS dependency and not at the cost of blowing things up on another machine. Therefore, L turns on additional checking, but only when it thinks it's running in a test file in a VCS checkout -- although if this causes undesired behaviour this can be overridden by setting the C environment variable. If additional useful author side checks come to mind, I'll add them to the C code path only -- this will result in a minor version increase (e.g. 1.000000 to 1.001000 (1.1.0) or similar). Any fixes only to the mechanism of this code will result in a sub-version increase (e.g. 1.000000 to 1.000001 (1.0.1)). If the behaviour of C in normal mode changes in any way, that will constitute a major version increase -- and the code already checks when its version is tested to ensure that use strictures 1; will continue to only introduce the current set of strictures even if 2.0 is installed. =head1 METHODS =head2 import This method does the setup work described above in L =head2 VERSION This method traps the C<< strictures->VERSION(1) >> call produced by a use line with a version number on it and does the version check. =head1 EXTRA TESTING RATIONALE Every so often, somebody complains that they're deploying via C and that they don't want L to enable itself in this case -- and that setting C to 0 isn't acceptable (additional ways to disable extra testing would be welcome but the discussion never seems to get that far). In order to allow us to skip a couple of stages and get straight to a productive conversation, here's my current rationale for turning the extra testing on via a heuristic: The extra testing is all stuff that only ever blows up at compile time; this is intentional. So the oft-raised concern that it's different code being tested is only sort of the case -- none of the modules involved affect the final optree to my knowledge, so the author gets some additional compile time crashes which he/she then fixes, and the rest of the testing is completely valid for all environments. The point of the extra testing -- especially C -- is to catch mistakes that newbie users won't even realise are mistakes without help. For example, foo { ... }; where foo is an & prototyped sub that you forgot to import -- this is pernicious to track down since all I fine until it gets called and you get a crash. Worse still, you can fail to have imported it due to a circular require, at which point you have a load order dependent bug which I've seen before now I show up in production due to tiny differences between the production and the development environment. I wrote L to explain this particular problem before L itself existed. As such, in my experience so far L' extra testing has I production versus development differences, not caused them. Additionally, L' policy is very much "try and provide as much protection as possible for newbies -- who won't think about whether there's an option to turn on or not" -- so having only the environment variable is not sufficient to achieve that (I get to explain that you need to add C at least once a week on freenode #perl -- newbies sometimes completely skip steps because they don't understand that that step is important). I make no claims that the heuristic is perfect -- it's already been evolved significantly over time, especially for 1.004 where we changed things to ensure it only fires on files in your checkout (rather than L-using modules you happened to have installed, which was just silly). However, I hope the above clarifies why a heuristic approach is not only necessary but desirable from a point of view of providing new users with as much safety as possible, and will allow any future discussion on the subject to focus on "how do we minimise annoyance to people deploying from checkouts intentionally". =head1 SEE ALSO =over 4 =item * L =item * L =item * L =back =head1 COMMUNITY AND SUPPORT =head2 IRC channel irc.perl.org #toolchain (or bug 'mst' in query on there or freenode) =head2 Git repository Gitweb is on http://git.shadowcat.co.uk/ and the clone URL is: git clone git://git.shadowcat.co.uk/p5sagit/strictures.git The web interface to the repository is at: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/strictures.git =head1 AUTHOR mst - Matt S. Trout (cpan:MSTROUT) =head1 CONTRIBUTORS Karen Etheridge (cpan:ETHER) Mithaldu - Christian Walde (cpan:MITHALDU) haarg - Graham Knop (cpan:HAARG) =head1 COPYRIGHT Copyright (c) 2010 the strictures L and L as listed above. =head1 LICENSE This library is free software and may be distributed under the same terms as perl itself. =cut